Author Topic: compile  (Read 5777 times)

Offline raft

  • quad
  • ******
  • Posts: 1972
    • View Profile
    • http://www.aptalkarga.com
Re: compile
« Reply #15 on: August 22, 2010, 05:19:59 pm »
Quote from: EgonOlsen
This can only happen if rendering interleaves with the build()...shareCompiledData()-sequence somehow.
not sure about this. new particles are added in update method and rendering comes afterwards. and all is done in same thread

Offline EgonOlsen

  • Administrator
  • quad
  • *****
  • Posts: 11776
    • View Profile
    • http://www.jpct.net
Re: compile
« Reply #16 on: August 22, 2010, 08:05:28 pm »
Ok...but...this is the code in question:

Code: [Select]
if (obj.shareWith != null && !obj.sharing) {
       // Copy compiled data from another object
obj.sharing = true;
if (obj.compiled.size() != obj.shareWith.compiled.size()) {
Logger.log("Number of compiled instances don't match...can't share data!", Logger.ERROR);
return;
}

for (int i = 0; i < obj.compiled.size(); i++) {
CompiledInstance dcis = obj.compiled.get(i);
CompiledInstance scis = obj.shareWith.compiled.get(i);

if (Config.useVBO && gl11 != null && vboPossible && !dynamic) {
scis.createBuffers(gl11, rendy);
}

dcis.copy(scis);
}
filled = true;
Logger.log("Object '" + obj.getName() + "' shares compiled data with object '" + obj.shareWith.getName() + "'");
}

if (!filled) {
Logger.log("render() called on an uncompiled object (" + obj.getName() + ")!", Logger.WARNING);
return;
}

As you can see, filled is set to true right before the message about sharing is being printed out (it appears in your log too). Then, filled is checked...it can't be set to false in between, because there is no code that sets it to false anywhere in the engine. There's only one other part that sets it to true and that is after compiling an object that doesn't share data. So i don't see a way that can cause this except for some thread interaction between building/compiling/sharing/rendering...
« Last Edit: August 22, 2010, 08:35:34 pm by EgonOlsen »

Offline raft

  • quad
  • ******
  • Posts: 1972
    • View Profile
    • http://www.aptalkarga.com
Re: compile
« Reply #17 on: August 22, 2010, 08:43:37 pm »
you may be right, can't access code at the moment. isn't there a chance build(false) can interfere with it ?

Offline EgonOlsen

  • Administrator
  • quad
  • *****
  • Posts: 11776
    • View Profile
    • http://www.jpct.net
Re: compile
« Reply #18 on: August 22, 2010, 08:52:43 pm »
If done in another thread, then yes...i suppose... ;)

Offline raft

  • quad
  • ******
  • Posts: 1972
    • View Profile
    • http://www.aptalkarga.com
Re: compile
« Reply #19 on: August 23, 2010, 12:46:26 am »
well, this is really strange, i've tried but i couldnt create a test case ???

gui thread is involved, it loads the level, creates the world and objects but since then render thread is unaware of the world. then world is passed to renderer and game goes on..

i've made some tests. this happens only if sharedCompileData is called on the object in question (calling build(false) doesnt matter). the master object is constructed via add addTriangle(..) methods. if i pass -1 as texture id, this exception doesnt happen. really weird.

one more thing, this happens consistently at very first render, which suggest this is not a multi thread issue.

Offline raft

  • quad
  • ******
  • Posts: 1972
    • View Profile
    • http://www.aptalkarga.com
Re: compile
« Reply #20 on: August 23, 2010, 12:51:26 am »
this has definetely have something with texture id's. below is a test case.
uncomment the lines 44-45 to get rid of exception. really weird ???

Code: [Select]
package tmp;

import javax.microedition.khronos.egl.EGL10;
import javax.microedition.khronos.egl.EGLConfig;
import javax.microedition.khronos.egl.EGLDisplay;
import javax.microedition.khronos.opengles.GL10;

import raft.jumpy.JConfig;
import android.app.Activity;
import android.opengl.GLSurfaceView;
import android.os.Bundle;

import com.threed.jpct.Camera;
import com.threed.jpct.FrameBuffer;
import com.threed.jpct.Object3D;
import com.threed.jpct.RGBColor;
import com.threed.jpct.SimpleVector;
import com.threed.jpct.Texture;
import com.threed.jpct.TextureManager;
import com.threed.jpct.World;
import com.threed.jpct.util.MemoryHelper;

/**
 *
 * @author  hakan eryargi (r a f t)
 */
public class Test2Activity extends Activity {

private static final float HALF_SIDE = 0.35f;
private static final float HEIGHT = 4f;

private static final Object3D MAGNET_PLANE_MASTER;
static {
TextureManager.getInstance().addTexture("white", new Texture(64, 64, RGBColor.WHITE));
TextureManager.getInstance().addTexture("blue", new Texture(64, 64, RGBColor.BLUE));


MAGNET_PLANE_MASTER = new Object3D(10);

int shiftTextureId = TextureManager.getInstance().getTextureID("blue");
int topTextureId = TextureManager.getInstance().getTextureID("white");

// uncomment these lines
// shiftTextureId = -1;
// topTextureId = -1;


// front side (looking from front)
MAGNET_PLANE_MASTER.addTriangle(
new SimpleVector(-HALF_SIDE, 0, -HALF_SIDE), 0, 0, // lower left
new SimpleVector(HALF_SIDE, 0, -HALF_SIDE), 1, 0, // lower right 
new SimpleVector(-HALF_SIDE, -HEIGHT, -HALF_SIDE), 0, 0.5f, // upper left
shiftTextureId);
MAGNET_PLANE_MASTER.addTriangle(
new SimpleVector(HALF_SIDE, 0, -HALF_SIDE), 1, 0, // lower right 
new SimpleVector(HALF_SIDE, -HEIGHT, -HALF_SIDE), 1, 0.5f, // upper right
new SimpleVector(-HALF_SIDE, -HEIGHT, -HALF_SIDE), 0, 0.5f, // upper left
shiftTextureId);

// back side (looking from front)
MAGNET_PLANE_MASTER.addTriangle(
new SimpleVector(HALF_SIDE, 0, HALF_SIDE), 1, 0, // lower right 
new SimpleVector(-HALF_SIDE, 0, HALF_SIDE), 0, 0, // lower left
new SimpleVector(HALF_SIDE, -HEIGHT, HALF_SIDE), 1, 0.5f, // upper right
shiftTextureId);
MAGNET_PLANE_MASTER.addTriangle(
new SimpleVector(-HALF_SIDE, 0, HALF_SIDE), 0, 0, // lower left
new SimpleVector(-HALF_SIDE, -HEIGHT, HALF_SIDE), 0, 0.5f, // upper left
new SimpleVector(HALF_SIDE, -HEIGHT, HALF_SIDE), 1, 0.5f, // upper right
shiftTextureId);

// right side (looking from right)
MAGNET_PLANE_MASTER.addTriangle(
new SimpleVector(HALF_SIDE, 0, -HALF_SIDE), 0, 0, // lower left
new SimpleVector(HALF_SIDE, 0, HALF_SIDE), 1, 0, // lower right 
new SimpleVector(HALF_SIDE, -HEIGHT, -HALF_SIDE), 0, 0.5f, // upper left
shiftTextureId);
MAGNET_PLANE_MASTER.addTriangle(
new SimpleVector(HALF_SIDE, 0, HALF_SIDE), 1, 0, // lower right 
new SimpleVector(HALF_SIDE, -HEIGHT, HALF_SIDE), 1, 0.5f, // upper right
new SimpleVector(HALF_SIDE, -HEIGHT, -HALF_SIDE), 0, 0.5f, // upper left
shiftTextureId);

// left side (looking from left)
MAGNET_PLANE_MASTER.addTriangle(
new SimpleVector(-HALF_SIDE, 0, HALF_SIDE), 0, 0, // lower left
new SimpleVector(-HALF_SIDE, 0, -HALF_SIDE), 1, 0, // lower right 
new SimpleVector(-HALF_SIDE, -HEIGHT, HALF_SIDE), 0, 0.5f, // upper left
shiftTextureId);
MAGNET_PLANE_MASTER.addTriangle(
new SimpleVector(-HALF_SIDE, 0, -HALF_SIDE), 1, 0, // lower right 
new SimpleVector(-HALF_SIDE, -HEIGHT, -HALF_SIDE), 1, 0.5f, // upper right
new SimpleVector(-HALF_SIDE, -HEIGHT, HALF_SIDE), 0, 0.5f, // upper left
shiftTextureId);

// top side (looking from top)
MAGNET_PLANE_MASTER.addTriangle(
new SimpleVector(-HALF_SIDE, -HEIGHT, -HALF_SIDE), 0, 0, // lower left
new SimpleVector(HALF_SIDE, -HEIGHT, HALF_SIDE), 1, 0.5f, // upper right
new SimpleVector(-HALF_SIDE, -HEIGHT, HALF_SIDE), 0, 0.5f, // upper left
topTextureId);
MAGNET_PLANE_MASTER.addTriangle(
new SimpleVector(HALF_SIDE, -HEIGHT, -HALF_SIDE), 1, 0, // lower right 
new SimpleVector(HALF_SIDE, -HEIGHT, HALF_SIDE), 1, 0.5f, // upper right
new SimpleVector(-HALF_SIDE, -HEIGHT, -HALF_SIDE), 0, 0, // lower left
topTextureId);

//MAGNET_PLANE_MASTER.translate(0, -0.5f, 0);
MAGNET_PLANE_MASTER.translateMesh();
MAGNET_PLANE_MASTER.getTranslationMatrix().setIdentity();

//MAGNET_PLANE_MASTER.setTexture("tile_MAGNET_PLANE");
MAGNET_PLANE_MASTER.getMesh().compress();

//MAGNET_PLANE_MASTER.setBillboarding(Object3D.BILLBOARDING_ENABLED);
MAGNET_PLANE_MASTER.setTransparency((int)(JConfig.transparencyRange / 1.5f));
//MAGNET_PLANE_MASTER.setTransparencyMode(Object3D.TRANSPARENCY_MODE_ADD);
MAGNET_PLANE_MASTER.setLighting(Object3D.LIGHTING_NO_LIGHTS);
MAGNET_PLANE_MASTER.setAdditionalColor(RGBColor.WHITE);

MAGNET_PLANE_MASTER.compile();
}

private GLSurfaceView mGLView;
private final MyRenderer renderer = new MyRenderer();

private World world;
private boolean compileAll;

@Override
protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
mGLView = new GLSurfaceView(getApplication());
setContentView(mGLView);

mGLView.setEGLConfigChooser(new GLSurfaceView.EGLConfigChooser() {
public EGLConfig chooseConfig(EGL10 egl, EGLDisplay display) {
// Ensure that we get a 16bit framebuffer. Otherwise, we'll fall
// back to Pixelflinger on some device (read: Samsung I7500)
int[] attributes = new int[] { EGL10.EGL_DEPTH_SIZE, 16, EGL10.EGL_NONE };
EGLConfig[] configs = new EGLConfig[1];
int[] result = new int[1];
egl.eglChooseConfig(display, attributes, configs, 1, result);
return configs[0];
}
});

mGLView.setRenderer(renderer);

world = new World();
world.getCamera().moveCamera(Camera.CAMERA_MOVEOUT, 2);


Object3D magnetBox = MAGNET_PLANE_MASTER.cloneObject();
magnetBox.shareCompiledData(MAGNET_PLANE_MASTER);

world.addObject(magnetBox);

compileAll = true;
}


@Override
protected void onPause() {
super.onPause();
mGLView.onPause();
}

@Override
protected void onResume() {
super.onResume();
mGLView.onResume();
}

class MyRenderer implements GLSurfaceView.Renderer {

private FrameBuffer buffer = null;

public MyRenderer() {
}

@Override
public void onSurfaceChanged(GL10 gl, int width, int height) {
if (buffer != null) {
buffer.dispose();
}
buffer = new FrameBuffer(gl, width, height);
MemoryHelper.compact();
}

@Override
public void onSurfaceCreated(GL10 gl, EGLConfig config) {
}

@Override
public void onDrawFrame(GL10 gl) {
if (buffer == null)
return;

buffer.clear();

if (compileAll) {
world.compileAllObjects(buffer);
compileAll = false;
}

world.renderScene(buffer);
world.draw(buffer);

buffer.display();
Thread.yield();

}
}

}

Offline EgonOlsen

  • Administrator
  • quad
  • *****
  • Posts: 11776
    • View Profile
    • http://www.jpct.net
Re: compile
« Reply #21 on: August 23, 2010, 06:35:32 am »
I would rather think that this has something to do with the time it takes to upload an addional texture and not with the texture id itself. Because that wouldn't make any sense. Your code example fails all the time or just now and then?

Offline raft

  • quad
  • ******
  • Posts: 1972
    • View Profile
    • http://www.aptalkarga.com
Re: compile
« Reply #22 on: August 23, 2010, 12:08:06 pm »
all the time, at least till now all my trials failed. with those lines uncommented, always succeded ???

edit: fixed the typo: uncommented code always succeeds
« Last Edit: August 23, 2010, 02:46:47 pm by raft »

Offline EgonOlsen

  • Administrator
  • quad
  • *****
  • Posts: 11776
    • View Profile
    • http://www.jpct.net
Re: compile
« Reply #23 on: August 23, 2010, 05:16:08 pm »
I'll see if i can reproduce this problem. Have you tried if it helps to synchronize object creation and rendering?

Offline raft

  • quad
  • ******
  • Posts: 1972
    • View Profile
    • http://www.aptalkarga.com
Re: compile
« Reply #24 on: August 23, 2010, 05:38:53 pm »
no, i didn't try it. i cant access the code at the moment

Offline raft

  • quad
  • ******
  • Posts: 1972
    • View Profile
    • http://www.aptalkarga.com
Re: compile
« Reply #25 on: August 23, 2010, 09:10:26 pm »
here is the synchronized version of test case. just to be sure, every jPCT related thing is aggresively synchronized. result is the same. setting texture id's to -1 fixes the exception

Code: [Select]
package tmp;

import javax.microedition.khronos.egl.EGL10;
import javax.microedition.khronos.egl.EGLConfig;
import javax.microedition.khronos.egl.EGLDisplay;
import javax.microedition.khronos.opengles.GL10;

import raft.jumpy.JConfig;
import android.app.Activity;
import android.opengl.GLSurfaceView;
import android.os.Bundle;

import com.threed.jpct.Camera;
import com.threed.jpct.FrameBuffer;
import com.threed.jpct.Object3D;
import com.threed.jpct.RGBColor;
import com.threed.jpct.SimpleVector;
import com.threed.jpct.Texture;
import com.threed.jpct.TextureManager;
import com.threed.jpct.World;
import com.threed.jpct.util.MemoryHelper;

/**
 *
 * @author  hakan eryargi (r a f t)
 */
public class Test2Activity extends Activity {

private static final float HALF_SIDE = 0.35f;
private static final float HEIGHT = 4f;

private static final Object lock = new Object();

private static final Object3D MAGNET_PLANE_MASTER;
static {
synchronized (lock) {
TextureManager.getInstance().addTexture("white", new Texture(64, 64, RGBColor.WHITE));
TextureManager.getInstance().addTexture("blue", new Texture(64, 64, RGBColor.BLUE));


MAGNET_PLANE_MASTER = new Object3D(10);

int shiftTextureId = TextureManager.getInstance().getTextureID("blue");
int topTextureId = TextureManager.getInstance().getTextureID("white");

// uncomment these lines
// shiftTextureId = -1;
// topTextureId = -1;


// front side (looking from front)
MAGNET_PLANE_MASTER.addTriangle(
new SimpleVector(-HALF_SIDE, 0, -HALF_SIDE), 0, 0, // lower left
new SimpleVector(HALF_SIDE, 0, -HALF_SIDE), 1, 0, // lower right 
new SimpleVector(-HALF_SIDE, -HEIGHT, -HALF_SIDE), 0, 0.5f, // upper left
shiftTextureId);
MAGNET_PLANE_MASTER.addTriangle(
new SimpleVector(HALF_SIDE, 0, -HALF_SIDE), 1, 0, // lower right 
new SimpleVector(HALF_SIDE, -HEIGHT, -HALF_SIDE), 1, 0.5f, // upper right
new SimpleVector(-HALF_SIDE, -HEIGHT, -HALF_SIDE), 0, 0.5f, // upper left
shiftTextureId);

// back side (looking from front)
MAGNET_PLANE_MASTER.addTriangle(
new SimpleVector(HALF_SIDE, 0, HALF_SIDE), 1, 0, // lower right 
new SimpleVector(-HALF_SIDE, 0, HALF_SIDE), 0, 0, // lower left
new SimpleVector(HALF_SIDE, -HEIGHT, HALF_SIDE), 1, 0.5f, // upper right
shiftTextureId);
MAGNET_PLANE_MASTER.addTriangle(
new SimpleVector(-HALF_SIDE, 0, HALF_SIDE), 0, 0, // lower left
new SimpleVector(-HALF_SIDE, -HEIGHT, HALF_SIDE), 0, 0.5f, // upper left
new SimpleVector(HALF_SIDE, -HEIGHT, HALF_SIDE), 1, 0.5f, // upper right
shiftTextureId);

// right side (looking from right)
MAGNET_PLANE_MASTER.addTriangle(
new SimpleVector(HALF_SIDE, 0, -HALF_SIDE), 0, 0, // lower left
new SimpleVector(HALF_SIDE, 0, HALF_SIDE), 1, 0, // lower right 
new SimpleVector(HALF_SIDE, -HEIGHT, -HALF_SIDE), 0, 0.5f, // upper left
shiftTextureId);
MAGNET_PLANE_MASTER.addTriangle(
new SimpleVector(HALF_SIDE, 0, HALF_SIDE), 1, 0, // lower right 
new SimpleVector(HALF_SIDE, -HEIGHT, HALF_SIDE), 1, 0.5f, // upper right
new SimpleVector(HALF_SIDE, -HEIGHT, -HALF_SIDE), 0, 0.5f, // upper left
shiftTextureId);

// left side (looking from left)
MAGNET_PLANE_MASTER.addTriangle(
new SimpleVector(-HALF_SIDE, 0, HALF_SIDE), 0, 0, // lower left
new SimpleVector(-HALF_SIDE, 0, -HALF_SIDE), 1, 0, // lower right 
new SimpleVector(-HALF_SIDE, -HEIGHT, HALF_SIDE), 0, 0.5f, // upper left
shiftTextureId);
MAGNET_PLANE_MASTER.addTriangle(
new SimpleVector(-HALF_SIDE, 0, -HALF_SIDE), 1, 0, // lower right 
new SimpleVector(-HALF_SIDE, -HEIGHT, -HALF_SIDE), 1, 0.5f, // upper right
new SimpleVector(-HALF_SIDE, -HEIGHT, HALF_SIDE), 0, 0.5f, // upper left
shiftTextureId);

// top side (looking from top)
MAGNET_PLANE_MASTER.addTriangle(
new SimpleVector(-HALF_SIDE, -HEIGHT, -HALF_SIDE), 0, 0, // lower left
new SimpleVector(HALF_SIDE, -HEIGHT, HALF_SIDE), 1, 0.5f, // upper right
new SimpleVector(-HALF_SIDE, -HEIGHT, HALF_SIDE), 0, 0.5f, // upper left
topTextureId);
MAGNET_PLANE_MASTER.addTriangle(
new SimpleVector(HALF_SIDE, -HEIGHT, -HALF_SIDE), 1, 0, // lower right 
new SimpleVector(HALF_SIDE, -HEIGHT, HALF_SIDE), 1, 0.5f, // upper right
new SimpleVector(-HALF_SIDE, -HEIGHT, -HALF_SIDE), 0, 0, // lower left
topTextureId);

//MAGNET_PLANE_MASTER.translate(0, -0.5f, 0);
MAGNET_PLANE_MASTER.translateMesh();
MAGNET_PLANE_MASTER.getTranslationMatrix().setIdentity();

//MAGNET_PLANE_MASTER.setTexture("tile_MAGNET_PLANE");
MAGNET_PLANE_MASTER.getMesh().compress();

//MAGNET_PLANE_MASTER.setBillboarding(Object3D.BILLBOARDING_ENABLED);
MAGNET_PLANE_MASTER.setTransparency((int)(JConfig.transparencyRange / 1.5f));
//MAGNET_PLANE_MASTER.setTransparencyMode(Object3D.TRANSPARENCY_MODE_ADD);
MAGNET_PLANE_MASTER.setLighting(Object3D.LIGHTING_NO_LIGHTS);
MAGNET_PLANE_MASTER.setAdditionalColor(RGBColor.WHITE);

MAGNET_PLANE_MASTER.compile();
}
}

private GLSurfaceView mGLView;
private final MyRenderer renderer = new MyRenderer();

private World world;
private boolean compileAll;

@Override
protected void onCreate(Bundle savedInstanceState) {
synchronized (lock) {
        super.onCreate(savedInstanceState);
mGLView = new GLSurfaceView(getApplication());
setContentView(mGLView);

mGLView.setEGLConfigChooser(new GLSurfaceView.EGLConfigChooser() {
public EGLConfig chooseConfig(EGL10 egl, EGLDisplay display) {
// Ensure that we get a 16bit framebuffer. Otherwise, we'll fall
// back to Pixelflinger on some device (read: Samsung I7500)
int[] attributes = new int[] { EGL10.EGL_DEPTH_SIZE, 16, EGL10.EGL_NONE };
EGLConfig[] configs = new EGLConfig[1];
int[] result = new int[1];
egl.eglChooseConfig(display, attributes, configs, 1, result);
return configs[0];
}
});

mGLView.setRenderer(renderer);

world = new World();
world.getCamera().moveCamera(Camera.CAMERA_MOVEOUT, 2);


Object3D magnetBox = MAGNET_PLANE_MASTER.cloneObject();
magnetBox.shareCompiledData(MAGNET_PLANE_MASTER);

world.addObject(magnetBox);

compileAll = true;
}
}


@Override
protected void onPause() {
super.onPause();
mGLView.onPause();
}

@Override
protected void onResume() {
super.onResume();
mGLView.onResume();
}

class MyRenderer implements GLSurfaceView.Renderer {

private FrameBuffer buffer = null;

public MyRenderer() {
}

@Override
public void onSurfaceChanged(GL10 gl, int width, int height) {
synchronized (lock) {
if (buffer != null) {
buffer.dispose();
}
buffer = new FrameBuffer(gl, width, height);
MemoryHelper.compact();
}
}

@Override
public void onSurfaceCreated(GL10 gl, EGLConfig config) {
}

@Override
public void onDrawFrame(GL10 gl) {
synchronized (lock) {
if (buffer == null)
return;

buffer.clear();

if (compileAll) {
world.compileAllObjects(buffer);
compileAll = false;
}

world.renderScene(buffer);
world.draw(buffer);

buffer.display();
Thread.yield();
}
}
}

}


Offline EgonOlsen

  • Administrator
  • quad
  • *****
  • Posts: 11776
    • View Profile
    • http://www.jpct.net
Re: compile
« Reply #26 on: August 23, 2010, 09:43:15 pm »
I can reproduce it in the emulator...i'm going to investigate this now...

Offline EgonOlsen

  • Administrator
  • quad
  • *****
  • Posts: 11776
    • View Profile
    • http://www.jpct.net
Re: compile
« Reply #27 on: August 23, 2010, 10:05:53 pm »
Fixed! I've uploaded a new AE jar as well as a new beta jar of desktop jPCT into the usual directories. The problem was, that sharing failed on objects that compiled down into more than one sub-object, which happened in your test case when using multiple textures (and not just -1 for both). In that case, only the first sub-object was marked as being filled, all others were still marked as not being filled (though they were actually filled correctly).
This should be fixed now, please try the new jar.
« Last Edit: August 23, 2010, 11:02:09 pm by EgonOlsen »

Offline raft

  • quad
  • ******
  • Posts: 1972
    • View Profile
    • http://www.aptalkarga.com
Re: compile
« Reply #28 on: August 23, 2010, 10:54:52 pm »
ok, it's ok now, thanks :D