Author Topic: INioBufferTextureEffect  (Read 1606 times)

Offline raft

  • quad
  • ******
  • Posts: 1972
    • View Profile
    • http://www.aptalkarga.com
INioBufferTextureEffect
« on: January 03, 2014, 08:09:36 pm »
can I suggest adding a new version of ITextureEffect which accepts java.nio.Buffer and channel ordering?

I'm experimenting with the idea of mixing OpenCV with jPCT and making them to render to same GLSurfaceView as I mentioned in this thread. the pipeline is something like:

* take android's camera preview data (byte[]) and put into an OpenCV Mat1 object
* modify and/or process Mat via OpenCV
* copy final contents of Mat into a jPCT texture via an ITextureEffect
* blit that texture as background
* render 3d content over that

all is fine for now except the fps. some profiling suggests most of the time is spent in ITextureEffect.apply(..) method.

there are two issues:
* jPCT wants texture data in ARGB channel order but OpenCV supports RGBA and BGRA, not ARGB
* jPCT wants all channels embedded into an int but OpenCV gives chanels as different bytes (or float/short/int whatever depth is used)

so I take the byte array from OpenCV, iterate over that, re-arrange the bytes and create an int out of that. jPCT takes that and puts them into a nio.Buffer, quite a waste.

long story short, it may be good idea to add a new version of ITextureEffect which accepts java.nio.Buffer and channel ordering. unless of course there is a better way?

as an implementation detail, this new one can extend from the current ITextureEffect to keep things simple:

Code: [Select]
interface INioBufferTextureEffect extends ITextureEffect {
    // channel order maybe return type or a setting in Config.
    // if filling in source is costly, it can even be skipped based on a setting in Config
    void apply(java.nio.Buffer dest, java.nio.Buffer source);
}

1: Mat is an OpenCV matrix like structure which can hold and convert to a matrix of arbitrary depth. pixels of an image or a perspective transform for example.

Offline EgonOlsen

  • Administrator
  • quad
  • *****
  • Posts: 11777
    • View Profile
    • http://www.jpct.net
Re: INioBufferTextureEffect
« Reply #1 on: January 03, 2014, 08:55:42 pm »
Sounds reasonable, albeit it will render some other settings in Texture (like 4bpp) useless. Another way to implement that would be to add some method to Texture itself that simply takes the NIO-buffer and it's format (RGBA or BGRA), overrides the actual texel data and uploads the buffer instead. This would only work if no texture compression, no 4bpp and no mipmaps are being used. Any other case would raise an error. Would that be sufficient?

Offline raft

  • quad
  • ******
  • Posts: 1972
    • View Profile
    • http://www.aptalkarga.com
Re: INioBufferTextureEffect
« Reply #2 on: January 03, 2014, 09:02:32 pm »
yes, sounds perfectly sufficient :)

Offline EgonOlsen

  • Administrator
  • quad
  • *****
  • Posts: 11777
    • View Profile
    • http://www.jpct.net
Re: INioBufferTextureEffect
« Reply #3 on: January 03, 2014, 09:15:14 pm »
The only remaining question: Should that data survive a context change? Personally, i don't think that this is needed...

Offline raft

  • quad
  • ******
  • Posts: 1972
    • View Profile
    • http://www.aptalkarga.com
Re: INioBufferTextureEffect
« Reply #4 on: January 03, 2014, 09:20:05 pm »
no definetely not in this scenario. if camera data should persist, the Mat should survive not the texture itself.

Offline EgonOlsen

  • Administrator
  • quad
  • *****
  • Posts: 11777
    • View Profile
    • http://www.jpct.net
Re: INioBufferTextureEffect
« Reply #5 on: January 03, 2014, 10:03:44 pm »
Try this jar: http://jpct.de/download/beta/jpct_ae.jar

It adds a method overrideTexelData(<ByteBuffer>); to Texture. As said, no mip maps, texture compression or 4bpp are allowed and the buffer has to have a size that matches the one of the texture (i.e. width*height*4). Format is limited to RGBA, because BGRA isn't well supported at least in OpenGL ES 1.x (that means: It's only available as part of an extension and i got a black texture when trying it...). It worked for me and was pretty fast.

Offline raft

  • quad
  • ******
  • Posts: 1972
    • View Profile
    • http://www.aptalkarga.com
Re: INioBufferTextureEffect
« Reply #6 on: January 03, 2014, 10:07:00 pm »
awesome. you are still the #1 maintainer as always :) i'll try it on monday at job. thx

Offline raft

  • quad
  • ******
  • Posts: 1972
    • View Profile
    • http://www.aptalkarga.com
Re: INioBufferTextureEffect
« Reply #7 on: January 06, 2014, 09:01:49 am »
it's working as a charm, thx :)

Offline EgonOlsen

  • Administrator
  • quad
  • *****
  • Posts: 11777
    • View Profile
    • http://www.jpct.net
Re: INioBufferTextureEffect
« Reply #8 on: January 06, 2014, 08:41:04 pm »
How is performance with that solution?

Offline raft

  • quad
  • ******
  • Posts: 1972
    • View Profile
    • http://www.aptalkarga.com
Re: INioBufferTextureEffect
« Reply #9 on: January 07, 2014, 09:06:25 am »
quite fast :) there was two bottlenecks according to profiling results: the major one was this and other one was scaling camera image to a 2^n sized image for using as a texture. both eliminated and it's quite fast at the moment.

for some numerics: previously 320x240 camera preview was working ~20 fps on samsung s3, now 1280x720 preview works at ~20 fps. using a wrapped ByteBuffer even takes that to 25+ fps


Offline raft

  • quad
  • ******
  • Posts: 1972
    • View Profile
    • http://www.aptalkarga.com
Re: INioBufferTextureEffect
« Reply #10 on: January 16, 2014, 03:53:42 pm »
does this new overrideTexelData method consumes data when it's called or later? later I suppose, right?

i'm printing some debug data onto openCv image and experiencing some overlapping letters, this may be relevant

Offline EgonOlsen

  • Administrator
  • quad
  • *****
  • Posts: 11777
    • View Profile
    • http://www.jpct.net
Re: INioBufferTextureEffect
« Reply #11 on: January 16, 2014, 04:43:13 pm »
Later. It's just a different kind of texture upload that happens when the texture will be used the next time.